Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasmer key for Wasmer Edge #10

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Add wasmer key for Wasmer Edge #10

merged 2 commits into from
Apr 4, 2024

Conversation

syrusakbary
Copy link
Contributor

Adding wasmer key for Wasmer Edge

@syrusakbary
Copy link
Contributor Author

We just launched WinterJS publicly: https://wasmer.io/posts/announcing-winterjs

And I also joined WinterCG as well :)

What are the required steps to get this merged upstream? @lucacasonato

@syrusakbary
Copy link
Contributor Author

Hey @lucacasonato @jasnell, I recently joined the Winter Community Group and also WinterJS has been recently passing all conformance with the WinterCG runtime API https://github.com/wasmerio/winterjs?tab=readme-ov-file#wintercg-api-compatibility

Could we move this PR forward? Thanks!

@pi0 pi0 mentioned this pull request Mar 12, 2024
Closed
@syrusakbary
Copy link
Contributor Author

Friendly ping @lucacasonato @guybedford @flaki in case this passed off your radar :)

syrusakbary
syrusakbary commented Mar 12, 2024
View reviewed changes
index.bs Outdated Show resolved Hide resolved
@lucacasonato lucacasonato mentioned this pull request Mar 20, 2024
Open
lucacasonato
lucacasonato approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the meeting today

@lucacasonato lucacasonato merged commit c5c4697 into wintercg:main Apr 4, 2024
@syrusakbary
Copy link
Contributor Author

Thanks for discussing on the WinterCG meeting and finally merging @lucacasonato @jasnell 🙏

PS: I'd love to participate in the next WinterCG meeting, how could I join? I couldn't find any instructions online. Any help will be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@CanadaHonk CanadaHonk CanadaHonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@syrusakbary @lucacasonato @CanadaHonk