Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for overriden to() method #88

Closed
wants to merge 1 commit into from
Closed

Add unit test for overriden to() method #88

wants to merge 1 commit into from

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Jun 15, 2022

@mjauvin mjauvin requested a review from LukeTowers June 15, 2022 14:43
@mjauvin mjauvin self-assigned this Jun 15, 2022
@arvislacis
Copy link
Contributor

Although added test looks valid and useful, the actual result of failed cases is the same, I mean, if you decode https://www.example.com/path?array%5B%5D=v1&array%5B%5D=v2 then it's equal to https://www.example.com/path?array[]=v1&array[]=v2

Problems starts with https://www.example.com/path?array[0]=v1&array[1]=v2 which is then interpretated as https://www.example.com/path?array[0][]=v1&array[1][]=v2

@mjauvin
Copy link
Member Author

mjauvin commented Jun 15, 2022

@arvislacis Yes, I am aware of this, but @LukeTowers needed a test case that showed the issue in order to fix the problem.

LukeTowers added a commit that referenced this pull request Jun 25, 2022
@LukeTowers
Copy link
Member

Merged in 32df10c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants