You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The MessageLogged event listener in the ServiceProvider class excludes the event context instead of placing it in the details column (by passing it in as the details argument to EventLog::add). I have dynamically overridden this event locally for a while now with no ill effects and the stock output renders quite nicely as-is. I would like to submit a pull request to make this change upstream.
Additionally, a recent change added a type declaration to the EventLog::add function for the details parameter. The type declaration was set to ?string when the function assumes and even explicitly casts it to an array. The model has the details attribute set to JSONable, so I believe this type declaration is incorrect and causes needless double-encoding to JSON when using this function. I believe the type declaration should have been ?array instead.
Will this change be backwards-compatible?
I have had this event dynamically overridden in a custom plugin since version 1.0.x with no negative consequences, so it should be backward compatible.
The text was updated successfully, but these errors were encountered:
Package targeted
Winter CMS
Description
The MessageLogged event listener in the ServiceProvider class excludes the event context instead of placing it in the details column (by passing it in as the details argument to EventLog::add). I have dynamically overridden this event locally for a while now with no ill effects and the stock output renders quite nicely as-is. I would like to submit a pull request to make this change upstream.
Additionally, a recent change added a type declaration to the EventLog::add function for the details parameter. The type declaration was set to
?string
when the function assumes and even explicitly casts it to an array. The model has the details attribute set to JSONable, so I believe this type declaration is incorrect and causes needless double-encoding to JSON when using this function. I believe the type declaration should have been?array
instead.Will this change be backwards-compatible?
I have had this event dynamically overridden in a custom plugin since version 1.0.x with no negative consequences, so it should be backward compatible.
The text was updated successfully, but these errors were encountered: