Move scaffolding commands into System module

[bennothommo]

Package targeted

Both

Description

Currently, the scaffolding commands in Winter CMS (create:plugin, create:controller, etc.) reside in the Storm library for historical purposes.

It may, however, make more sense for these to reside in the System module in Winter CMS, as these functions relate directly to Winter CMS functionality, and require a Winter CMS install to be used effectively. They would not be able to be used in isolation with the Storm library.

If accepted, I intend to put forward a PR that moves all the create:* commands into the System module, but leaving the base Scaffolding classes and Service Provider within the Storm library.

The main benefit of this change will be that we can write test cases for the scaffold commands, as currently these are not tested within the Storm library, ostensibly because it's impossible to load the plugin architecture within the Storm library tests.

Will this change be backwards-compatible?

Mostly backwards-compatible, as most people will just use the commands directly, but it would break any custom implementations of these commands which may extend the original command.

[LukeTowers]

The theme commands should probably be moved to the CMS module then. Should we move the specific scaffolding commands into each applicable module? i.e.

System Module:

• plugin
• command
• model
• settings (when implemented)

Backend Module:

• Controller
• FormWidget
• ReportWidget

CMS Module:

• theme
• component

[bennothommo]

Yeah, I can definitely do it that way. I assumed we would just put them in System as those commands have traditionally been available at all times given that they've been provided by the Storm library, but it does make sense to make them only available if needed.

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[github-actions]

This issue will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this issue is still relevant or you would like to see it actioned, please respond and we will re-open this issue.
If this issue is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[LukeTowers]

Closed by e3fecdb