Sign in page should redirect authenticated users to the backend #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
reviewed
May 21, 2024
| @@ -52,6 +52,10 @@ public function index() | |||
| */ | |||
| public function signin() | |||
| { | |||
| if (BackendAuth::user()) { | |||
| return Backend::redirect('backend'); | |||
There was a problem hiding this comment.
The user doesn't necessarily have access to the dashboard, so it might be nice at some point to provide a helper method that would return the first menu item they have access to and use that instead, but this is probably good enough for now given that the current behaviour is just showing them the signin page when they're already logged in.
LukeTowers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logged in users should not be allowed to stay on this page without logging out first.