trigger a new ajaxRedirect event and handle it in the loading indicator #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
reviewed
Apr 8, 2021
…ct response via AJAX. Fixes: octobercms/october#5555 Tested by wintercms/wn-test-plugin@9fb25e2 Refs: - octobercms/october#5055 (original issue attempted to solve with previous code) - octobercms/october#2780 (original issue regarding the hash change redirect not closing the loading indicator) - octobercms/october@99a0861 (October's solution to the issue)
LukeTowers
added a commit
that referenced
this pull request
Apr 13, 2021
* develop: Improves Froala richeditor link insertion via the pagelinks plugin Improve reliability of context sidenav partials Trigger a new ajaxRedirected event and handle it in the loading indicator (#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner way to disable loading indicator when an AJAX handler returns a redirect reponse.
ref. octobercms/october@99a0861
ref. octobercms/october#5555
ref. octobercms/october#5055
replaces octobercms/october#5321