Respect Template Options in Before Blocks #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winton
added a commit
that referenced
this pull request
Jan 16, 2013
Respect Template Options in Before Blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bug while trying to use compass. When calling render in a before block (Stasis::Render#render) configuration set with
Stasis::Options.set_template_optionwas ignored. This patch merges options passed at the end of a call torenderinside abeforeblock withStasis::Options.get_template_option-- I was inspired by Stasis#renderPlease see issue #31's comments for some history.
I wrote two specs, they feel a little gross, but I don't know how else to test this behavior.