Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block merge of squash! or fixup! commits #55

Closed
blairconrad opened this issue Mar 15, 2018 · 2 comments
Closed

block merge of squash! or fixup! commits #55

blairconrad opened this issue Mar 15, 2018 · 2 comments

Comments

@blairconrad
Copy link

blairconrad commented Mar 15, 2018

A feature request. I'm often involved in workflows where responses to code review comments result in fixup or squash commits being added to the PR. These are subsequently used with an --autosquash rebase flag and auto-squashed. Or fixed up.

(I assume you're familiar with this, but if not, a nice introduction can be had at George Brocklehurst's Auto-squashing Git Commits.)

The presence of these commits strongly indicates that work is still in progress. Could wip-bot block them as well?

@blairconrad
Copy link
Author

I'd be willing to work on the feature, if it's deemed useful, but probably not until early April.

@gr2m
Copy link
Collaborator

gr2m commented Jun 15, 2018

closing in favor of #96 – would love your input there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants