Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It got stuck #58

Closed
zeke opened this issue Mar 17, 2018 · 5 comments
Closed

It got stuck #58

zeke opened this issue Mar 17, 2018 · 5 comments

Comments

@zeke
Copy link

zeke commented Mar 17, 2018

This PR's title was changed, but the WIP check is still pending.

electron/simple-samples#15

screen shot 2018-03-16 at 9 15 39 pm

@codebytere
Copy link

I think this might be because my first commit contained WIP which looks like intended behavior per the commitContainsWIP() method...does this mean that it’s not possible to mark a PR as being ready unless i force push and rewrite history?

@gr2m
Copy link
Collaborator

gr2m commented Mar 17, 2018

does this mean that it’s not possible to mark a PR as being ready unless i force push and rewrite history?

Yes. But you are not the first to be confused by it, I’m thinking to remove the parsing of commit messages altogether or to make it configurable.

By the way if something’s not working have a look at http://wip-bot.now.sh/_logs, the logs are public, it just doesn’t log for private repositories logs are no longer public as of 5/25/18

@gr2m
Copy link
Collaborator

gr2m commented Mar 17, 2018

so yeah, electron/simple-samples#15 is blocked because of the WIP commit

@gr2m gr2m closed this as completed Mar 17, 2018
@zeke
Copy link
Author

zeke commented Mar 17, 2018

I’m thinking to remove the parsing of commit messages altogether

I didn't realize it was checking commit messages. I thought it was just based on PR title.

@gr2m
Copy link
Collaborator

gr2m commented Mar 17, 2018

Yeah I wish there was a way to communicate with users of an GitHub app ...
I documented the places it checks at https://github.com/gr2m/wip-bot#usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants