Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error with some compilers #6

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lars18th
Copy link
Contributor

@lars18th lars18th commented Mar 7, 2024

Hi @wirbel-at-vdr-portal ,

This patch fixes one compilation error with some compilers. The problem is inside the boolean operators. You're using the "this" reference, with the const parameter of the other instance. However, if you don't declare the function const the compiler doesn't work because the "this" pointer is not considered const.

This simple change fixes this compilation error.
I hope you want to merge it.

@wirbel-at-vdr-portal
Copy link
Owner

Which compiler on which system is it?

@lars18th
Copy link
Contributor Author

Which compiler on which system is it?

Now I'm not sure about the concrete compiler, but the fact this: the "this" pinter requires to be const in this context.

Please, remember that I'm only an engineer that in my free time I'm contributing to improve this software. So, I hope that you be a little more open-minded with the help of others. I understand that you don't want to merge anything that is not tested, not useful or not well designed. But I don't have the time to spend in this project without any benefit. With this patch, my expectation was: "if it compiles on your system, then it's valid for merging". I'm sorry, but what's the problem now?

@wirbel-at-vdr-portal
Copy link
Owner

Similar, hw engineer, working on this dtv scanner plugin on spare time without any benefit since ~2004-01-04 (soon to 20yrs anniversary), providing the plugin for others - just for fun.

But i need to understand any detail, as i also support maintainers, who get this into several linux distributions, ie. debian (taken over by ubuntu, kubuntu, raspbian) && arch linux. And i'm getting the bug reports later.

Will check && come back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants