Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: plublish to wire-maven #6

Merged
merged 2 commits into from Mar 10, 2022
Merged

chore: plublish to wire-maven #6

merged 2 commits into from Mar 10, 2022

Conversation

tmspzz
Copy link
Contributor

@tmspzz tmspzz commented Mar 10, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The publishing task is set to publish to ../local-maven which is inconvenient given that we want to temporarily publish to ../wire-maven/releases at wire-maven

Solutions

Change the publish uri to ../wire-maven/releases and correct the artifact's name


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@tmspzz tmspzz requested a review from typfel March 10, 2022 10:46
@typfel
Copy link
Member

typfel commented Mar 10, 2022

Can we instructions for how to setup your machine for publishing to https://github.com/wireapp/wire-maven in its README

@tmspzz tmspzz merged commit fa6889e into main Mar 10, 2022
@tmspzz tmspzz deleted the chore/publish-to-wire-maven branch March 10, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants