Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support P384 #3

Merged
merged 1 commit into from
Sep 7, 2022
Merged

feat: support P384 #3

merged 1 commit into from
Sep 7, 2022

Conversation

beltram
Copy link
Member

@beltram beltram commented Sep 7, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Support P384 EcDSA signature scheme


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #3 (7b2f8d8) into main (ceeb171) will increase coverage by 6.48%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   77.19%   83.67%   +6.48%     
==========================================
  Files           7        7              
  Lines          57       98      +41     
==========================================
+ Hits           44       82      +38     
- Misses         13       16       +3     

@beltram beltram changed the title suport P384 feat: support P384 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants