Feature : Show conversation history - part 1 - Show conversation history in chat screen #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_history_part0 # Conflicts: # app/src/main/kotlin/com/wire/android/feature/conversation/di/ConversationsModule.kt # app/src/main/kotlin/com/wire/android/feature/conversation/list/ui/ConversationListFragment.kt
ohassine
changed the title
ohassine
changed the title
…tion_history_part1 # Conflicts: # app/src/main/kotlin/com/wire/android/feature/conversation/content/ui/ConversationActivity.kt # app/src/main/kotlin/com/wire/android/feature/conversation/content/ui/ConversationFragment.kt # app/src/main/kotlin/com/wire/android/feature/conversation/di/ConversationsModule.kt # app/src/main/kotlin/com/wire/android/feature/conversation/list/ui/ConversationListFragment.kt # app/src/main/res/layout/fragment_conversation.xml # app/src/main/res/values/styles_textview.xml
mejdoo
suggested changes
Jul 9, 2021
...n/com/wire/android/feature/conversation/content/datasources/local/MessageAndContactEntity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/feature/conversation/content/ui/ConversationViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/feature/conversation/content/ui/ConversationActivity.kt
Outdated
Show resolved
Hide resolved
| class ConversationTextMessageViewHolder(parent: ViewGroup, inflater: ViewHolderInflater) : | ||
| RecyclerView.ViewHolder(inflater.inflate(R.layout.conversation_chat_item_text, parent)) { | ||
|
|
||
| private val conversationChatItemUsernameTextView by lazyFind<TextView>(R.id.conversationChatItemUsernameTextView) |
There was a problem hiding this comment.
I think you can get rid of those 3 lines and call directly conversationChatItemUsernameTextView , conversationChatItemTextMessageTextView and conversationChatItemUserAvatarImageView
There was a problem hiding this comment.
Kotlin Synthetics is deprecated, I think we should use findViewById or migrate to Jetpack View Binding.
About migration:
https://developer.android.com/topic/libraries/view-binding/migration
There was a problem hiding this comment.
Let's do the migration later in different PRs ;)
…ance tests reports are stored (#234)
Yeah @mejdoo still work in progress, I am working on unit test |
mejdoo
approved these changes
Jul 12, 2021
...n/com/wire/android/feature/conversation/content/datasources/local/MessageAndContactEntity.kt
Outdated
Show resolved
Hide resolved
vitorhugods
approved these changes
Jul 12, 2021
...est/kotlin/com/wire/android/feature/conversation/content/datasources/local/MessageDaoTest.kt
Outdated
Show resolved
Hide resolved
… into show_conversation_history_part1 # Conflicts: # app/src/androidTest/kotlin/com/wire/android/feature/conversation/content/datasources/local/MessageDaoTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
This PR is a follow up of #231.
It aims to display the conversation chat history.
Showing message's time, displaying the right profile picture and dark mode will be done in the following PRs