fix: fix bug not displaying asset messages correctly #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongracr
requested review from
typfel,
yamilmedina,
alexandreferris,
borichellow and
vitorhugods
|
Build 1 succeeded. The build produced the following APK's: |
saleniuk
reviewed
Apr 19, 2022
app/src/main/kotlin/com/wire/android/ui/home/conversations/ConversationViewModel.kt
Show resolved
Hide resolved
|
Build 2 failed. |
…to fix/bug_asset_messages # Conflicts: # kalium
|
Build 5 succeeded. The build produced the following APK's: |
saleniuk
approved these changes
Apr 19, 2022
typfel
approved these changes
Apr 19, 2022
…to fix/bug_asset_messages # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/conversations/MessageItem.kt # kalium
|
Build 6 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
This PR contains the fix in kalium needed to show correctly on AR, asset messages sent by web clients
Needs releases with:
fix: bug not downloading correctly asset messages from web client kalium#413
How to Test
Log in on your web client account, try to send an asset message to a given conversation. Open the AR app, check that the asset placeholder gets displayed correctly on the same conversation
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.