Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WireSwitch #734

Merged
merged 5 commits into from Jul 1, 2022
Merged

feat: add WireSwitch #734

merged 5 commits into from Jul 1, 2022

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jul 1, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Default switch have wrong colors.

Solutions

Implemented our own color scheme for switch and wrapper called WireSwitch.

Testing

How to Test

Currently this switch is added only to DebugScreen.

Attachments (Optional)

image


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Unit Test Results

  29 files  ±0    29 suites  ±0   26s ⏱️ +2s
162 tests ±0  162 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit f23e79c. ± Comparison against base commit 5256c6e.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 2 succeeded.

The build produced the following APK's:

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #734 (f23e79c) into develop (5256c6e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop     #734      +/-   ##
=============================================
- Coverage      15.24%   15.20%   -0.05%     
  Complexity       320      320              
=============================================
  Files            226      226              
  Lines           9766     9792      +26     
  Branches        1594     1597       +3     
=============================================
  Hits            1489     1489              
- Misses          8152     8178      +26     
  Partials         125      125              
Impacted Files Coverage Δ
...lin/com/wire/android/ui/debugscreen/DebugScreen.kt 0.00% <0.00%> (ø)
...ns/details/options/GroupConversationOptionsItem.kt 0.00% <0.00%> (ø)

@saleniuk saleniuk merged commit 7533f67 into develop Jul 1, 2022
@saleniuk saleniuk deleted the feat/wire_switch branch July 1, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants