feat: prepare for implementing action action handler for protocol update [WPB-5266] #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caldrian
changed the base branch from
develop
to
feat/proteus-to-mls-migration
caldrian
commented
Nov 15, 2023
Comment on lines
+72
to
+76
| expectedData: Data?, | ||
| expectedContentType: String?, | ||
| apiVersion: APIVersion = .v1, | ||
| file: StaticString = #filePath, | ||
| line: UInt = #line |
There was a problem hiding this comment.
Make argument types optional, add file and line in order to show XCTAssert-warnings on the proper place.
Comment on lines
+481
to
+487
| let id: UUID? | ||
| let data: T | ||
| let from: UUID? | ||
| let qualifiedID: QualifiedID? | ||
| let qualifiedFrom: QualifiedID? | ||
| let timestamp: Date? | ||
| let type: String? |
There was a problem hiding this comment.
Sorted properties according to their order in the Swagger document.
Datadog ReportBranch report: ✅ |
Co-authored-by: David-Henner <david.henner@wire.com>
…re-ios into feat/prepare-for-implementing-action-action-handler-for-protocol-update-WPB-5266
markusfassbender
approved these changes
Nov 16, 2023
…plementing-action-action-handler-for-protocol-update-WPB-5266
markusfassbender
merged commit 1c6687c
into
feat/proteus-to-mls-migration
9 checks passed
markusfassbender
deleted the
feat/prepare-for-implementing-action-action-handler-for-protocol-update-WPB-5266
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
A few adjustments which are independent of the actual implementation of the protocol update action+handler, which will be done in PR #684.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.