Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Access-Control-Allow-Origin Header still an issue in 2017? #1134

Closed
segahm opened this issue Apr 27, 2017 · 10 comments
Closed

Is Access-Control-Allow-Origin Header still an issue in 2017? #1134

segahm opened this issue Apr 27, 2017 · 10 comments
Assignees

Comments

@segahm
Copy link

segahm commented Apr 27, 2017

Referring to #294
Please instruct whether it is now possible to use webapp on a non-wire domain. If not, this would be defeat the whole purpose of a project - no?

@segahm
Copy link
Author

segahm commented Apr 27, 2017

I seem to be able to login successfully from a Localhost. Just wondering what are the limitations.

@bennycode
Copy link
Contributor

@segahm, your question is valid and tough at the sime time.

The current limitation (when using our production backend from a localhost) is that you will not be able to refresh the access token, so _schedule_token_refresh will fail and you will get logged out on your browser.

I am forwarding your question to our Head of Security, @raphaelrobert.

@segahm
Copy link
Author

segahm commented May 1, 2017

@raphaelrobert nice to meet you. How should I treat what @bennyn is describing? As a bug, a security feature, or something else? Thanks

@raphaelrobert
Copy link

Sorry for the late reply. The limitation mentioned in #294 is still in place for now.
This is a security feature, in that the CORS prevents access from other websites. Unfortunately that includes self-hosted versions as well.

@segahm
Copy link
Author

segahm commented May 4, 2017

Hmm. @raphaelrobert @bennyn please advise how I should proceed then.

I am building a product on top of Wire Webapp chat client, with the hope of registering my users in your network. Likewise, relying on your server. This is something I previously successfully prototyped on Telegram.

So far, the refresh access token is my only roadblock. I hypothesize that I have a workaround. But if the inability to refresh access token is not a bug but an intentional feature, I don't want to go about hacking together a solution that will be blocked down the road by the server.

Please help. Thank You. You can reach me at:
"first name" at "domain of the company I work for"

@raphaelrobert
Copy link

When modifying Wire clients and connecting to our servers, our Terms of Use apply, in particular section 6.4. Please be mindful of that.

Our server API is not publicly documented and we reserve the right to change it without prior notice. Going forward it will be possible to self-host the Wire backend. In the meantime our bot API is maybe more suited for your needs.

@segahm
Copy link
Author

segahm commented May 8, 2017

@priiduzilmer can you chime on this. The above is not very encouraging from the standpoint of an open source developer team putting its time and money.

@raphaelrobert
Copy link

@segahm The Wire servers are simply not suited to build third-party services on top of it, that's the reason we don't allow it.
As I mentioned, the bot API was designed specifically with that objective.
If you would like to describe in more detail what you are trying to build, feel free to write to Wire Support and we can look into it further.

@segahm
Copy link
Author

segahm commented May 15, 2017

@raphaelrobert @priiduzilmer I've responded on Medium where the CTO states: "Wire’s users can now build their own client from our source code and run it on our platform"

I am now puzzled by the response above.

@gregor gregor closed this as completed Oct 3, 2017
@gregor
Copy link
Contributor

gregor commented Oct 3, 2017

Closing due to inactivity. Concerns are being addressed step by step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants