[RELEASE] v1.3.0 #80
Merged
[RELEASE] v1.3.0 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[REBASE] Master into develop
[FEAT] Transfers
Feat(escrow): add release escrow feature
IsaacYung
approved these changes
Apr 2, 2018
suga
reviewed
Apr 3, 2018
| Resource::Transfer.new client.get("#{base_path}/#{transfers_id}") | ||
| end | ||
|
|
||
| def find_all(limit: nil, offset: nil, filters: nil, status: nil) |
There was a problem hiding this comment.
Esse método de buscar tudo, está me parecendo com muitas responsabilidades. Ele está aplicando uma regra nos parametros recebidos e está transformando a resposta.
Poderíamos tratar esse parametros antes deles serem injetados no find_all? Ou criar um método privado aonde o nome diga o que esta sendo feito para esse tratamento?
A response a mesma coisa, poderíamos criar pelo menos um método privado? Ou tratar ela na camada de cima aonde o find_all está sendo chamado?
Fazendo isso podemos tirar esses comentários tb :)
suga
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release
v1.3.0.