Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Flutter 3.13 compatibility #292

Merged
merged 2 commits into from Aug 17, 2023
Merged

Fixes for Flutter 3.13 compatibility #292

merged 2 commits into from Aug 17, 2023

Conversation

JishnuM
Copy link
Contributor

@JishnuM JishnuM commented Aug 17, 2023

Fixes #291

isAlwaysShown replaced by thumbVisibility in flutter/flutter#96957

@BirjuVachhani
Copy link

@JishnuM Can you please fix _cornerRadiusAnimation in wiredash_backdrop.dart too? ClipRRect can't have nullable borderRadius.

@JishnuM
Copy link
Contributor Author

JishnuM commented Aug 17, 2023

@JishnuM Can you please fix _cornerRadiusAnimation in wiredash_backdrop.dart too? ClipRRect can't have nullable borderRadius.

Done, pushed a commit for this

@JishnuM JishnuM changed the title Replace isAlwaysShown with thumbVisibility Fixes for Flutter 3.13 compatibility Aug 17, 2023
@passsy
Copy link
Member

passsy commented Aug 17, 2023

thumbVisibility was introduced in Flutter 3.0.0 which matches the current minSdkVersion of Wiredash 👍

@passsy passsy merged commit 2d8a5b3 into wiredashio:stable Aug 17, 2023
3 of 4 checks passed
@JishnuM JishnuM deleted the feat/fix-deprecated-scrollbar branch August 17, 2023 12:43
@passsy
Copy link
Member

passsy commented Aug 17, 2023

Fix has been released 1.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter 3.13: No named parameter with the name 'isAlwaysShown'.
3 participants
@JishnuM @BirjuVachhani @passsy