Close Thread Handle after thread join on Windows #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
|
||
| WT_RET_MSG(session, ret, "WaitForSingleObject"); | ||
| return (0); |
There was a problem hiding this comment.
- Should we do something with "ret", maybe use it as the second argument to the
WT_PANIC_RETcall so we get an idea whyWaitForSingleObjectfailed? If not, then I think we can remove the use ofretin this function. - Also, it looks to me like
CloseHandlecan fail (see here), should we check and panic in that case as well?
There was a problem hiding this comment.
- Good suggestion. I was unsure what to pass to WT_PANIC in this case for that argument.
- I cleaned up CloseHandle in this function, and everywhere else.
|
Test PASSed. |
|
This looks great, @markbenvenuto, thank you, I'll merge. |
keithbostic
added a commit
that referenced
this pull request
Jan 26, 2015
Close Thread Handle after thread join on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows after a thread exits, there is still one last remaining reference to the thread handle, and a program is required to call CloseHandle to free the last reference otherwise there is handle leak. The last reference allows thread creators to check on the status of thread, etc.
Fixes SERVER-17025