Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-2492 Change printf format specifier to be Windows compatible. #2591

Merged
merged 3 commits into from Mar 17, 2016

Conversation

agorrod
Copy link
Member

@agorrod agorrod commented Mar 16, 2016

Windows doesn't like "td" for ptrdiff_t

@agorrod
Copy link
Member Author

agorrod commented Mar 16, 2016

@keithbostic Could you please review this? It is causing failures in the Jenkins Windows build http://build.wiredtiger.com:8080/job/wiredtiger-basic-windows-tester/

Windows doesn't like %td, use the maximum unsigned integer format
instead, PRIuMAX.

Get rid of the temporary variable I introduced in cc0d34b, there's
no need for one.
@keithbostic
Copy link
Contributor

@agorrod, I think the safer format to use is PRIuMAX (although I'm sure PRIu64 would work).

Since there isn't a specifier that works on all platforms.
@keithbostic
Copy link
Contributor

@agorrod, lgtm, merged.

keithbostic added a commit that referenced this pull request Mar 17, 2016
WT-2492 Change printf format specifier to be Windows compatible.
@keithbostic keithbostic merged commit 83bb8a3 into develop Mar 17, 2016
@keithbostic keithbostic deleted the wt-2492 branch March 17, 2016 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants