WT-3575 ASCII statistics log printing #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for JSON configuration before logging the table name in JSON format. Minor KNF/whitespace.
…now. When logging statistics, log them when closing down the system.
sueloverso
approved these changes
Sep 12, 2017
| ",statistics=(fast)" | ||
| ",statistics_log=(wait=5,sources=(\"file:\"))"); | ||
| ",statistics=(fast),statistics_log=" | ||
| "(json,on_close,wait=5,sources=(\"file:\"))"); |
There was a problem hiding this comment.
Is it intentional to change test/format's use of statistics in this ticket as it is not really related to the problem of the ticket? Or is this a leftover from your testing?
There was a problem hiding this comment.
Yes, that was intentional, our default is JSON now (t2), and setting on_close exercises an additional code path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.