WT-3603 format threads always traverse the same RNG space. #3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialize the format threads to run in different parts of the RNG space 70% of the time.
no change other than semantic sugar.
|
Thanks @keithbostic lgtm |
|
Actually @keithbostic I was on the verge of merging this, but then thought the option may be critical for reproducing failures - do you think it should be exposed via the configuration file? |
I think that's a good point (and it's not like configuration variables are expensive to add). I've pushed that change for your consideration. |
"independent_thread_rng".
|
Thanks @keithbostic lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at one of the WT-3435/#3644 failures, I realized all of the format threads were pounding on the same key/value pairs. Interestingly enough, if you change that, the failure goes away.
I think we generally want the format threads to work different parts of the RNG space, but clearly we also want to stress the same key/value pairs as well.