WT-5689 reduce work required for the cursor-pinned test. #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…going to return true in all cases.
agorrod
approved these changes
Feb 27, 2020
sulabhM
reviewed
Feb 27, 2020
| * "normal" state and then test against that state (eviction may have already locked the page | ||
| * again). | ||
| */ | ||
| while ((current_state = cbt->ref->state) == WT_REF_LOCKED) |
There was a problem hiding this comment.
Can eviction be locking the page at this point, don't we need to wait till we get a REF_MEM state.
There was a problem hiding this comment.
Even if we got a WT_REF_MEM state, it wouldn't be permanent, that is, it could be flipped back to WT_REF_LOCKED after we look at it.
Basically, this is all safe because we're holding a hazard pointer on the page, so even if eviction takes a run at the WT_REF and locks it, eviction won't be able to actually evict the page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sulabhM, this change went in as part of WT-5256, here's the commit .
Assuming your change was correct, I think we can just simplify the whole thing?