Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-6625 Remove outdated TODO #5983

Merged
merged 1 commit into from Aug 28, 2020
Merged

WT-6625 Remove outdated TODO #5983

merged 1 commit into from Aug 28, 2020

Conversation

tetsuo-cpp
Copy link
Contributor

@tetsuo-cpp tetsuo-cpp commented Aug 27, 2020

This TODO comment refers to a ticket that has been closed which was flagged by some PM script.

We still don't know what to do about checkpoint cursors yet but we do have WT-5927 to track this issue so I've replaced it with a FIXME and marked it appropriately.

Copy link
Contributor

@quchenhao quchenhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not directly change the usage of checkpoint cursor? We can use simulate_crash_restart to achieve the same behavior I think.

@tetsuo-cpp
Copy link
Contributor Author

Why not directly change the usage of checkpoint cursor? We can use simulate_crash_restart to achieve the same behavior I think.

That invalidates the test. It's specifically about reading from history store which isn't the case if you restart and run rollback to stable.

I could move that part to the end of the test if you'd prefer that. The reason I haven't done this is because we're not sure what will happen with checkpoint cursors and may want to revert the original version of this test.

Copy link
Contributor

@quchenhao quchenhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'm fine waiting until we have made a decision on checkpoint cursor.

Copy link
Contributor

@hbokhari hbokhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Better to leave the test intact so we can revisit once checkpoint cursors are operational again.

@tetsuo-cpp tetsuo-cpp merged commit cf3c0c1 into develop Aug 28, 2020
@tetsuo-cpp tetsuo-cpp deleted the wt-6625-outdated-todo branch August 28, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants