WT-6741 Add check for supported data source on import #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetsuo-cpp
commented
Oct 8, 2020
|
|
||
| exclusive = __wt_config_getones(session, config, "exclusive", &cval) == 0 && cval.val != 0; | ||
| import = __wt_config_getones(session, config, "import.enabled", &cval) == 0 && cval.val != 0; |
There was a problem hiding this comment.
Since I'm doing the check up here, I decided to pass import into the helpers instead of doing redundant configuration parsing later.
There was a problem hiding this comment.
I just saw this go by. This is a good thing. Configuration parsing is expensive so avoiding multiple calls to parse is better. Create is not a critical path but it does add up.
sulabhM
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds checks and testing for when we try to import data sources other than
file:ortable:.The new logic checks the URI prefix and rejects any other data sources in the import case.