Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc #319

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

misc #319

wants to merge 4 commits into from

Conversation

koo5
Copy link

@koo5 koo5 commented Mar 21, 2023

can we disambiguate result and error like this?
and make max_size a parameter?
These are the two problems i ran into in my code querying this endpoint.

@antoinerabany
Copy link
Member

Hello and welcome,

That's fine by me, what would be your usage of this parameter ? Could you add a small test ?

Do you use remoulade for one of your project ?

Thank you !

@koo5
Copy link
Author

koo5 commented Jul 17, 2023

Hi!

yes, i use remoulade here: https://github.com/lodgeit-labs/accounts-assessor/
The usecase of max_size parameter would be to effectively disable the limit, it doesn't seem desirable in my usecase.
| Could you add a small test ?
i'll get to it eventually! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants