-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix admin requests with empty body to avoid response code 411 #1738
Conversation
I haven't added any extra tests as all of these scenarios are already exercised in the acceptance tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO it is still valid
Think we still need a test case for this. Although this code is exercised generally by the acceptance tests, there's nothing that produces the problem this is attempting to fix. |
@danielimre are you still interested in this pull request? |
@oleg-nenashev sure. Let me check if I can create a reasonable test for this. |
f665651
to
b1310a7
Compare
@oleg-nenashev I've put together some tests backing the changes. The simplest solution I've found without doing anything HTTP client specific stuff is to make use of wiremock itself to verify the behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test coverage!
Thanks @danielimre! |
Changed admin client to add empty response entity for HTTP requests without body to have proper Content-Length header set in every case. Closes #1729