-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxy request fix #1765
proxy request fix #1765
Conversation
fix request entity setting for any request methods
@tomakehurst could you please review this PR, this issue affects our tests. |
@AntonDyukarev please could you add a test case? |
@tomakehurst i'll try=) |
I think we just need some tests for HTTP methods other than PUT, POST, PATCH - I'd suggest going for GET and DELETE. |
@tomakehurst hi! I was added tests for get, post, put, delete and patch methods. But locally i has problem with keystorePath. The problem is X509CertificateVersion enum wich always is NULL, and i don't know why. Because of that locally tests failed. But without keystorePath, all tests passed (look at second picture). I don't think that it affects of my changes about proxy. Also for compare i ran same tests on master branch, and got fails with get and delete methods tests(look at third picture). |
@tomakehurst @AntonDyukarev any news on this one? |
Hi! I waiting for your answers about my tests |
@AntonDyukarev can you push your tests so I can take a look at the issue you encountered? |
@tomakehurst They already pushed |
@tomakehurst any news on this one? |
@tomakehurst could you please look at this PR? |
fix request entity setting for any request methods