Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Optional from the Jetty settings class #2214

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

pks-1981
Copy link
Contributor

@pks-1981 pks-1981 commented Jun 11, 2023

Proposal:
Jetty settings.
Removing Optional.

References

N/A

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Kirill Peshin added 3 commits June 11, 2023 13:38
Jetty settings.
Removing Optional.
@pks-1981
Copy link
Contributor Author

@tomakehurst @timtebeek
Hello
Plz review it

@timtebeek
Copy link
Contributor

Thanks for your continued effort here @pks-1981. I do feel I have to point out I don't currently have any special privileges on this repository, so apart from providing feedback on your pull request like any other GitHub user, I can't approve or merge your PRs at this time.

@tomakehurst tomakehurst merged commit f530a59 into wiremock:master Jun 14, 2023
7 checks passed
@pks-1981 pks-1981 deleted the jetty_settings branch June 14, 2023 14:28
@oleg-nenashev oleg-nenashev changed the title Proposal: Jetty settings. Removing Optional. Remove Optional from the Jetty settings class Jul 5, 2023
@oleg-nenashev oleg-nenashev added the chore Maintenance label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants