Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchesJsonSchemaPattern will return no match for null input #2223

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

Mahoney
Copy link
Collaborator

@Mahoney Mahoney commented Jun 15, 2023

An HTTP request without a body (e.g. GET, DELETE) passes null to the matcher which it used not to handle, causing all requests to the WireMock instance to fail.

This PR fixes that bug.

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

An HTTP request without a body (e.g. GET, DELETE) passes null to the
matcher which it used not to handle, causing all requests to the
WireMock instance to fail.
@Mahoney Mahoney force-pushed the fix-matches-json-schema-pattern-null-body branch from bf93600 to 4f2623a Compare June 15, 2023 16:00
@tomakehurst tomakehurst merged commit a0f880e into master Jun 15, 2023
6 of 7 checks passed
@tomakehurst tomakehurst deleted the fix-matches-json-schema-pattern-null-body branch June 15, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants