Do not use deprecated jackson iso8601 class #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
changed the title
tomakehurst
reviewed
Oct 9, 2023
| @@ -30,7 +30,9 @@ public static Integer toInt(QueryParameter parameter) { | |||
|
|
|||
| public static Date toDate(QueryParameter parameter) { | |||
| try { | |||
| return parameter.isPresent() ? new ISO8601DateFormat().parse(parameter.firstValue()) : null; | |||
| return parameter.isPresent() | |||
| ? new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'").parse(parameter.firstValue()) | |||
There was a problem hiding this comment.
Are we changing the contract here?
I think the class we're replacing will allow milliseconds whereas it looks like this won't.
There was a problem hiding this comment.
Ah fair point, I looked upon the usages and based myself upon the usage for ParseDateHelper which does not use ms. Do you prefer a singular contract or optional ms?
|
How about we use i.e. for formatting: DateTimeFormatter.ISO_ZONED_DATE_TIME.format(date.toInstant().atZone(ZoneId.of('Z')));parsing: Date.from(ZonedDateTime.parse(isoDateTimeString).toInstant()) |
tomakehurst
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used Jackson ISO8601 class is deprecated
References
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java