Fixed #2415 Gradle replaces SLF4J-API 1.7.36 with 2.0.7, causing warning in the log #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing warning about no providers in wiremock-standalone
oleg-nenashev
approved these changes
Oct 17, 2023
oleg-nenashev
changed the title
|
Need to tread carefully here. Let me take a proper look before we merge @oleg-nenashev |
|
Sure. My biggest concern would be regressions when other adapters are used |
|
Also, a test for non-standalone build would be needed since we hardcode the shaded classname |
|
Thanks! |
henrik242
pushed a commit
to henrik242/wiremock
that referenced
this pull request
Nov 10, 2023
…ing warning about no providers in wiremock-standalone (wiremock#2449)
Marvin9
pushed a commit
to Marvin9/wiremock
that referenced
this pull request
Nov 20, 2023
…ing warning about no providers in wiremock-standalone (wiremock#2449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it locally in a Maven project.
I had the warning before the fix, not after.
I'm not sure how to perform unit testing on it, though...