Substitutable HTTP client #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahoney
reviewed
Oct 24, 2023
| throws IOException { | ||
| final List<HttpHeader> headers = | ||
| Arrays.stream(apacheResponse.getHeaders()) | ||
| .collect(groupingBy(NameValuePair::getName)) |
There was a problem hiding this comment.
I suspect this is case sensitive - perhaps lower case the name?
| } | ||
|
|
||
| protected ImmutableRequest( | ||
| String absouteUrl, |
There was a problem hiding this comment.
typo, should be absoluteUrl
| byte[] body, | ||
| boolean multipart, | ||
| boolean browserProxyRequest) { | ||
| this.absouteUrl = absouteUrl; |
There was a problem hiding this comment.
Perhaps use Objects.requireNonNull for all the fields that can't be null?
|
|
||
| HttpUriRequest httpRequest = getHttpRequestFor(responseDefinition); |
There was a problem hiding this comment.
I think HttpClientFactory.getHttpRequestFor is now unused
There was a problem hiding this comment.
Gonna leave this in case anybody depends on it I think
|
Minor comments, looks great otherwise |
…and made ProxyResponseRenderer use this instead of the Apache client directly. Still to do: make this configurable via Options/extension.
…bject and via an extension in the same manner has HttpServerFactory, allowing the client factory to be set via options or via an extension.
…this instead of its own hard-coded http client.
tomakehurst
force-pushed
the
substitutable-http-client
branch
from
45c151a
to
80bb84b
Compare
…, fixed a typo, wrote a test to demonstrate correct header case handling
henrik242
pushed a commit
to henrik242/wiremock
that referenced
this pull request
Nov 10, 2023
* Created an HttpClient interface with an Apache client implementation and made ProxyResponseRenderer use this instead of the Apache client directly. * Added an HttpClientFactory interface that's returned by the options object and via an extension in the same manner has HttpServerFactory, allowing the client factory to be set via options or via an extension. * Made HttpClient a service passed to extensions and made webhooks use this instead of its own hard-coded http client.
Marvin9
pushed a commit
to Marvin9/wiremock
that referenced
this pull request
Nov 20, 2023
* Created an HttpClient interface with an Apache client implementation and made ProxyResponseRenderer use this instead of the Apache client directly. * Added an HttpClientFactory interface that's returned by the options object and via an extension in the same manner has HttpServerFactory, allowing the client factory to be set via options or via an extension. * Made HttpClient a service passed to extensions and made webhooks use this instead of its own hard-coded http client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates an
HttpClientabstraction within WireMock with a default Apache backed implementation. This is used in the proxy renderer and webhooks extension in place of the original directly referenced Apache clients.The HTTP client factory and a default implementation are made available as services to extensions.
The factory for the client can be substituted via the
Optionsobject or via an extension, following the same pattern as for the HTTP server.Doing this enables a few useful things: