Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: introduce a slight delay given the 2-3 results is slightly flakey #2463

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

SimonVerhoeven
Copy link
Contributor

References

Introduces a slight delay in the flakey test to hopefully avoid this in the future.

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, make sure you're signed up there and in the WireMock form
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@SimonVerhoeven SimonVerhoeven requested a review from a team as a code owner October 25, 2023 15:53
@oleg-nenashev oleg-nenashev added the chore Maintenance label Oct 25, 2023
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm. It will make the test lesss flaky but I do not think it will fix the issue entirely. I suggest creating a follow-up github issue and adding a FIXME comment with a reference

@tomakehurst
Copy link
Member

Please can you share some context on this?

I haven't noticed flakeyness in this test but if there is then it's probably an issue with the production code, and we should fix it rather than masking it with a delay.

@SimonVerhoeven
Copy link
Contributor Author

@tomakehurst
Copy link
Member

Actually, looking at this again I think this is a reasonable fix so I'll merge it. Might try dropping the delay values a bit after...

@tomakehurst tomakehurst merged commit ee2a7cd into wiremock:master Nov 2, 2023
7 checks passed
henrik242 pushed a commit to henrik242/wiremock that referenced this pull request Nov 10, 2023
Marvin9 pushed a commit to Marvin9/wiremock that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants