chore: use List.of where possible if only one argument is passed #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,20 +26,13 @@ public static String generate(String url, String prefix, String id) { | |||
|
|
|||
| public static String generate(String url, String prefix, String id, String extension) { | |||
| String pathPart = Urls.urlToPathParts(URI.create(url)); | |||
| pathPart = pathPart.equals("") ? "(root)" : sanitise(pathPart); | |||
| pathPart = pathPart.isEmpty() ? "(root)" : sanitise(pathPart); | |||
There was a problem hiding this comment.
Ideally should be isBlank() so that we handle more edge cases, but out of the scope for the PR title anyway
| @@ -158,7 +158,7 @@ public boolean remove(Object o) { | |||
| } | |||
|
|
|||
| public boolean containsAll(Collection<?> c) { | |||
| return data.containsAll(c); | |||
| return new HashSet<>(data).containsAll(c); | |||
There was a problem hiding this comment.
HashSet.containsAll tends to be faster.
There was a problem hiding this comment.
Of course, but you would need to iterate through all the elements at least once to form the new collection. It defeats the purpose of this change for most of the cases
henrik242
pushed a commit
to henrik242/wiremock
that referenced
this pull request
Nov 10, 2023
…emock#2468) * chore: use List.of where possible if only one argument is passed * chore: use isBlank
Marvin9
pushed a commit
to Marvin9/wiremock
that referenced
this pull request
Nov 20, 2023
…emock#2468) * chore: use List.of where possible if only one argument is passed * chore: use isBlank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up some Arrays.asList that were never adapted/only one arguments, and removed them in case they weren't used at all.
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java