-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gzipDisabled at the ResponseDefinitionBuilder level #2481
Conversation
I'm not sure just setting the content encoding header is enough to actually disable gzip. Would be good to see a test showing the the response is actually in plain text. |
@tomakehurst Ok, thanks for you feedback. I tried to illustrate it in test wireMockServerWithStubForWithGzipDisabledTrue. If i not understood what you want to see, please can explain one more time |
src/test/java/com/github/tomakehurst/wiremock/client/ResponseDefinitionBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/github/tomakehurst/wiremock/client/ResponseDefinitionBuilderTest.java
Outdated
Show resolved
Hide resolved
OK, from your screenshot it looks like just changing the header does actually affect the body encoding, which is a bit counterintuitive but if it works... |
src/test/java/com/github/tomakehurst/wiremock/client/ResponseDefinitionBuilderTest.java
Outdated
Show resolved
Hide resolved
@tomakehurst, Hi, I fixed comments, please review, when will you have free time |
Thanks! Please can open a documentation PR for this at https://github.com/wiremock/wiremock.org? |
Thanks for quick review! |
@tomakehurst Hi, I open documentation PR wiremock/wiremock.org#251 |
Greetings, please look at my PR for #2071
#help-contributing
or a project-specific channel like#wiremock-java