Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the version number to the output when wiremock starts #2485

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

leeturner
Copy link
Contributor

@leeturner leeturner commented Nov 10, 2023

This is a very simple PR to add the version number to the output when wiremock starts. I added it to the CommandlineOptions toString() method so the version is output regardless of whether the banner is enabled or not. I thought this might be better than adding the code in multiple places in the startup process. As far as I could tell there are no tests that validate the output of the startup process.

Output looks like this:

██     ██ ██ ██████  ███████ ███    ███  ██████   ██████ ██   ██ 
██     ██ ██ ██   ██ ██      ████  ████ ██    ██ ██      ██  ██  
██  █  ██ ██ ██████  █████   ██ ████ ██ ██    ██ ██      █████   
██ ███ ██ ██ ██   ██ ██      ██  ██  ██ ██    ██ ██      ██  ██  
 ███ ███  ██ ██   ██ ███████ ██      ██  ██████   ██████ ██   ██ 

----------------------------------------------------------------
|               Cloud: https://wiremock.io/cloud               |
|                                                              |
|               Slack: https://slack.wiremock.org              |
----------------------------------------------------------------

version:                      3.3.1
port:                         8080
enable-browser-proxying:      false
disable-banner:               false
no-request-journal:           false
verbose:                      false

extensions:                   response-template,webhook

References

https://wiremock-community.slack.com/archives/C03NAEH5LVA/p1699519576603569

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@leeturner leeturner requested a review from a team as a code owner November 10, 2023 17:33
@tomakehurst tomakehurst merged commit c28ca15 into wiremock:master Nov 13, 2023
7 checks passed
@tomakehurst
Copy link
Member

Thanks Lee!

Marvin9 pushed a commit to Marvin9/wiremock that referenced this pull request Nov 20, 2023
)

* Add the version number to the output when wiremock starts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants