Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number add to the endpoint /health - healthcheck Issue Nro 1339 #2498

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

gorostiaga
Copy link
Contributor

The version number was added to the endpoint /health
This partly covers the request on #1339

References

#1339

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • Recommended: If you participate in Hacktoberfest 2023, make sure you're signed up there and in the WireMock form
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@gorostiaga gorostiaga requested a review from a team as a code owner November 22, 2023 14:58
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks! A good defensive code would be to ensure the health check does not fail if version cannot be retrieved by resources, e.g. by catching runtime exceptions and putting something like "unknown"

@leeturner
Copy link
Contributor

+1, thanks! A good defensive code would be to ensure the health check does not fail if version cannot be retrieved by resources, e.g. by catching runtime exceptions and putting something like "unknown"

@oleg-nenashev That already happens in the Version class here

@oleg-nenashev
Copy link
Member

Great then!

@dieppa dieppa merged commit a0e7f21 into wiremock:master Jan 17, 2024
@dieppa
Copy link
Contributor

dieppa commented Jan 17, 2024

Good work!
Thanks for your contribution!
Merged ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants