Expose numberOfParameters on PathTemplate #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some specifications (e.g. [OpenAPI v3](https://spec.openapis.org/oas/v3.0.3#path-templating-matching)) require choosing a path template by how specific they are. Exposing the number of parameters allows sorting a set of templates by how specific they are.
Mahoney
commented
Nov 29, 2023
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| public class PathTemplate { | |||
| static final Pattern SPECIAL_SYMBOL_REGEX = | |||
| Pattern.compile("(?:\\{(?<variable>[^}]+)\\})|(?<wildcard>\\*\\*)"); | |||
| Pattern.compile("\\{(?<variable>[^}]+)}|(?<wildcard>\\*\\*)"); | |||
There was a problem hiding this comment.
IntelliJ told me these regex syntaxes were unnecessary, and removing them left all the tests passing, so I believed it.
tomakehurst
approved these changes
Nov 29, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some specifications (e.g. OpenAPI v3) require choosing a path template by how specific they are.
Exposing the number of parameters allows sorting a set of templates by how specific they are.
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java