Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and log warning before loading webhooks #2568

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

prithvitewatia
Copy link
Contributor

@prithvitewatia prithvitewatia commented Jan 11, 2024

Closes #2528.
This PR removes externally added webhooks as extensions and logs a warning that passing webhook class name is no longer required and may lead to compatibility issues in future.

Supersedes #2550

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@prithvitewatia prithvitewatia requested a review from a team as a code owner January 11, 2024 08:10
@tomakehurst tomakehurst merged commit a14e7f5 into wiremock:master Jan 15, 2024
7 checks passed
@tomakehurst
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Prevent fatal failure when passing the Webhooks classpath to the CLI args
2 participants