[FIX] Add a custom number comparator to the Json Diff to trim trailing zeros #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have set our ObjectMapper to not normalise BigDecimal values, we have an issue with the json Diff not seeing numbers like `1.2` and `1.2000` as the same values. This change adds a new Normalised Number Comparator to the Diff so we can continue to compare those values in the same way as we used to.
leeturner
commented
Feb 19, 2024
| @@ -257,4 +257,21 @@ public class MappingJsonSamples { | |||
| + " \"body\": \"国家标准\" \n" | |||
| + " } \n" | |||
| + "}\n"; | |||
|
|
|||
| public static final String MAPPING_REQUEST_JSON_BODY_DECIMALS_NO_TRAILING_ZEROS = | |||
There was a problem hiding this comment.
These \n were all aligned in the editor :)
RafeArnold
approved these changes
Feb 19, 2024
|
Is there also a risk that this is broken for |
I have added some tests to |
tomakehurst
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR 2588 we set our ObjectMapper to not normalise BigDecimal values. This fixed the undesirable behavior of values such as this -
{"float": 2.0}being changed to this -{"float": 2}. This PR maintains that behaviour.Because decimal values are no longer being normalised, this means we have an issue with the json Diff not seeing numbers like
1.2and1.2000as the same values. This change adds a newNumberComparatorto the Diff to normalise the BigDecimal values so we can continue to compare those values in the same way as we used to in versions prior to3.4.0.Submitter checklist
#help-contributingor a project-specific channel like#wiremock-javafixes #2610