-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSONPath performance tuning #2629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using the JsonPath parser
…che key to avoid clashes
…s as streams are for some reason very slow
… local one in the template engine instead of creating a separate instance
dieppa
reviewed
Mar 13, 2024
@@ -102,6 +103,8 @@ public void handle(Request request, HttpResponder httpResponder, ServeEvent orig | |||
|
|||
serveEvent.afterSend(); | |||
afterResponseSent(serveEvent, response); | |||
|
|||
RequestCache.onRequestEnd(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the risk that if, for any reason, an exception is thrown, the cache never gets to be cleaned.
…ot a match, thus saving unnecessary work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves match performance when using matchesJsonPath in multiple stubs by per-request caching parsed JSON documents and values resolved via evaluated JSONPath expressions.
Also includes some other tunings based on profiler output.