Refactoring #2662
Closed
Refactoring #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 23, 2024 13:27
This commit extracts multiple conditions in the if statement into separate variables for improved readability and maintainability.
This commit replaces the commented code with a call to the checkState() method for better readability and consistency in the codebase.
This commit refactors the like() method by extracting the logic for creating a ProxyResponseDefinitionBuilder into a separate method for better readability and maintainability of the codebase.
dieppa
reviewed
Apr 2, 2024
| @@ -71,6 +71,9 @@ public static ResponseDefinitionBuilder like(ResponseDefinition responseDefiniti | |||
| builder.wasConfigured = responseDefinition.isFromConfiguredStub(); | |||
|
|
|||
| if (builder.proxyBaseUrl != null) { | |||
| <<<<<<< HEAD | |||
| return createProxyResponseDefinitionBuilder(builder, responseDefinition); | |||
| ======= | |||
|
Hi @Shivang-X This PR looks like it has some of the same changes as your previous PR - #2647 It would be great if you could address the comments in the previous PR and then we can get that merged and closed off instead of adding the same changes to this PR |
|
Hi @Shivang-X I am just checking in on this PR to see if you are planning on moving it forwards to the point where we can merge it? No worries if not, I just wanted to check as we close PRs after a period of inactivity. Let me know your thoughts |
|
Closing due to inactivity and duplication across a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my current university course assignment, I need to improve the code by cleaning it up and making it easier to understand and modify (refactoring) whenever it's appropriate. And below mentioned are all refactoring.
Commit 1:
Performed "Replace condition with polymorphism" refactorng.
Commit 2:
Applied "Move method" refactoring.
Commit 3:
Performed "Extract Class" refactoring.
References
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java