Fixed #567 - Allow duplicate cookies

[mushanga]

Fixed #567

Issue
https://github.com/tomakehurst/wiremock/issues/567#issue-199911597

If I make a request with two values for one cookie, like this:
$ curl 'http://localhost:8080/test' -H 'Cookie: cookie1=190283aJDS;cookie1=190283aJDS'
I get the following response:

<title>Error 500 </title>

But if I remove the duplication, it works.

Reply
https://github.com/tomakehurst/wiremock/issues/567#issuecomment-272279919

Cookies are represented by a map internally and the map builder blows up if you try to add more than one with the same key.

Fix

• Changes in Cookie:
  • String name property added
  • Json value representation replaced with object
• Changes in interface Request: Map<String, Cookie> getCookies() method replaced with List<Cookie> getCookies()

[mushanga]

Is there a problem with openjdk7 tests? Seems that it's been failing since 7th of September

Please let me know if I should fix something in my pull request.

[tomakehurst]

Yeah, sorry about this. It's not your PR - I'm having problems with the Travis CI build image at the moment. Some combination of openjdk7, Gradle 4 and Travis' Linux image. I'm going to try and migrate to Circle CI today or tomorrow.

[mushanga]

Great, thanks! :)

[tomakehurst]

OK, the build is fixed on master now. If you merge across, it should go green.

Also, please could you make a few amendments to this PR:

The switch from Map<String, Cookie> to List<Cookie> on the Request interface breaks backwards compatibility (since this is an API class), so please could you restore this. I suggest instead that you modify the Cookie class so that it can take one or many values. Cookie is also an API class, so I suggest that you maintain its current interface but add extra methods to cope with the many values case.

This brings me to my 2nd point, which is that the way multi-valued headers are handled is to present the value as an array rather than a string when JSON serialised. I think it would make a lot of sense for cookies to be consistent with this, and a Cookie class that can handle many values would make this a lot easier.

Lastly, please could you add an acceptance test case for response templating with multiple cookie values.

Thanks!

[tomakehurst]

I've fixed this in 827e7cc