Prevent area copy exploit with CanTool hook check #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've grown tired of having to patch this myself. I wish CPPI wasn't used at all, and that the base/sandbox hooks could get called instead (like Wiremod has been moving toward the last year or so). If CPPI is not detected, this will default to running the CanTool hook, effectively preventing the Area Copy exploit for any servers that have prop protection addons that use CanTool. I have tested this and it appears to work fine. I encourage you to test it yourself, or even consider switching from CPPI to the base/sandbox hooks altogether.
|
In Wiremod we're definitely trying to switch away from CPPI towards CanTool. It's something we should probably be doing for advdupe2 as well. |
|
There, I dropped CPPI entirely from that bit :) |
|
Thank you very much! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CPPI is not detected, this will default to running the CanTool hook, effectively preventing the Area Copy exploit for any servers that have prop protection addons that use CanTool.
I've grown tired of having to patch this myself. I wish CPPI wasn't used at all, and that the base/sandbox hooks could get called instead (like Wiremod has been moving toward the last year or so).
I have tested this and it appears to work fine. I encourage you to test it yourself, or even consider switching from CPPI to the base/sandbox hooks altogether.