Skip to content

Commit

Permalink
DVB-S2-BB: Prevent infinite loop
Browse files Browse the repository at this point in the history
Commit 4bf4ee8 removed an else
statement that broke out of the BBFrame processing loop. Without
it, infinite loops might be possible if the GSE frames have bit errors
in the length field.


(cherry picked from commit 0137c24)
  • Loading branch information
johnthacker committed May 26, 2021
1 parent b20a776 commit 0d8be1f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions epan/dissectors/packet-dvb-s2-bb.c
Expand Up @@ -1257,6 +1257,8 @@ static int dissect_dvb_s2_bb(tvbuff_t *tvb, int cur_off, proto_tree *tree, packe
bb_data_len -= sub_dissected;
if (bb_data_len < DVB_S2_GSE_MINSIZE)
bb_data_len = 0;
} else {
bb_data_len = 0;
}
}
}
Expand Down

0 comments on commit 0d8be1f

Please sign in to comment.