Skip to content

Commit

Permalink
conversation: Remove conversation from the correct table
Browse files Browse the repository at this point in the history
In conversation_set_addr2, if the existing conversation has
a port2, remove it from the _no_addr2 hashtable, not the _no_port2
hashtable.

Fix #18766
  • Loading branch information
johnthacker committed Dec 30, 2022
1 parent dfd3a4d commit 55ffdb0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion epan/conversation.c
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ conversation_set_addr2(conversation_t *conv, const address *addr)
if (conv->options & NO_PORT2) {
conversation_remove_from_hashtable(conversation_hashtable_no_addr2_or_port2, conv);
} else {
conversation_remove_from_hashtable(conversation_hashtable_no_port2, conv);
conversation_remove_from_hashtable(conversation_hashtable_no_addr2, conv);
}

// Shift our endpoint and, if needed, our port element over and set our address.
Expand Down

0 comments on commit 55ffdb0

Please sign in to comment.