New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LTE message parsing #12
Conversation
Adds LTE message support. This code is borrowed from a patch proposed by altaf329@gmail.com in june 2015 and adapted to fit current wireshark code.
{ GSMTAP_TYPE_UMTS_RRC, "LTE RRC" },
{ GSMTAP_TYPE_UMTS_RRC, "LTE MAC" }, I think it should be: { GSMTAP_TYPE_LTE_RRC, "LTE RRC" },
{ GSMTAP_TYPE_LTE_MAC, "LTE MAC" }, |
Yes, thank you for pointing it. |
Yes, please push the fix on Gerrit https://code.wireshark.org/review/ |
Added to master in g551309a60e via Gerrit. Closing here. |
Remove the RSA UAT completely when built without GnuTLS, because we require GnuTLS for parsing PEM and PKCS wireshark#12 keys. RSA encrypted packets can still be decoded if they are using the standard OTServ RSA key, which is hard-coded. Bug: 13959 Change-Id: I6bfc2bebaf8a49933d55fb5c3fcb8efbf58f1e6e Fixes: g62c9a8a865 Reviewed-on: https://code.wireshark.org/review/23453 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Joakim Karlsson <oakimk@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
The path returned by get_persconffile_path needs to be freed. Direct leak of 64 byte(s) in 1 object(s) allocated from: #0 0x5653e6c98e06 in realloc (/home/vasko/sources/wireshark/build_clang/run/wireshark+0x2486e06) #1 0x7f5b697f2e7d in g_realloc gmem.c:164:16 #2 0x7f5b69810016 in g_string_maybe_expand gstring.c:102:21 #3 0x7f5b69810369 gstring.c:476:7 #4 0x7f5b69810369 in g_string_insert_len gstring.c:424:1 #5 0x7f5b697d808d in g_build_path_va gfileutils.c:1766:7 #6 0x7f5b697d9518 in g_build_filename_va gfileutils.c:1987:9 #7 0x7f5b697d9518 in g_build_filename gfileutils.c:2069:9 #8 0x7f5b69bd0c28 in get_persconffile_path /home/vasko/sources/wireshark/wsutil/filesystem.c:1856:12 #9 0x5653e8825f82 in extcap_get_extcap_paths /home/vasko/sources/wireshark/extcap.c:258:53 #10 0x5653e8825f82 in extcap_run_all /home/vasko/sources/wireshark/extcap.c:449 #11 0x5653e8825f82 in extcap_load_interface_list /home/vasko/sources/wireshark/extcap.c:2024 #12 0x5653e7775356 in main /home/vasko/sources/wireshark/ui/qt/main.cpp:726:5 Change-Id: I275d0ad6f06fbf3222c2d4ebef7f3079073404a0 Reviewed-on: https://code.wireshark.org/review/34994 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot Reviewed-by: Roland Knall <rknall@gmail.com>
Hi, thank you for your contribution! GitHub is however not the right place for these, please have a look at |
Adds LTE message support. This code is borrowed from a patch proposed by altaf329@gmail.com in june 2015 and adapted to fit current wireshark code.