Add monday first day support #319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haringsrob Thanks for contributing. The first day of the week is a great feature, but it's more complex than a boolean option to set only one day of the weekday. |
|
Hey @PH7-Jack, You are right. I did some checking before but must have missed the very few cases where it is not Monday or Sunday. I believe what would be the best way is to make use of this: However, I have no idea of how to add this to the setup, it could be combined with a global setting or a per field property. Thoughts? |
|
@haringsrob Sure, the dayjs plugins can be used to create this feature if needed. |
|
I'm closing this PR for now, we need a complete first-day-of-week solution to prevent futures break changes |
silviokennecke
added a commit
to silviokennecke/wireui
that referenced
this pull request
Nov 17, 2022
references wireui#319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋 ,
I could not find a way to set monday to be the first day of the week.
I think this implementation does the job.
See video for a demo
(individual date pickers can have their own state.)
<x-datetime-picker :monday-first-day="true"/>fixes #226 226